Skip to content

force logs as json #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

force logs as json #10

wants to merge 4 commits into from
+14 −2

Conversation

@prune998
Copy link

@prune998 prune998 commented Oct 6, 2020

Drone server is logging JSON by default.
This PR force the drone-runner-docker to log as JSON too.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tphoney
Copy link

tphoney commented Jul 20, 2021

Hey @prune998 thanks for the PR 🍺 !,
However this may have unforeseen implications of changing the output format, as people maybe relying on its current format. This is something that makes sense, would you change your PR to make this optional, so that it can be enabled by the end user if they choose.

@prune998
Copy link
Author

prune998 commented Jul 20, 2021

I'll look into this asap.

@prune998 prune998 force-pushed the prune/docker-runner-log-json branch from 16a979f to 89e7894 Compare July 20, 2021 20:40
@prune998
Copy link
Author

prune998 commented Jul 20, 2021

@tphoney I just added a bool flag to switch to json logs.
Please, review.

Thanks.

@bradrydzewski
Copy link
Collaborator

bradrydzewski commented Jul 21, 2021 •
edited
Loading

The exec command is used to manually run build locally from an interactive terminate which is why we have text logging as opposed to json logging. Not sure we want json logging here. But it makes sense for the daemon.

bradrydzewski
bradrydzewski reviewed Jul 21, 2021
View reviewed changes
command/exec.go
Procs int64
Debug bool
Trace bool
LogJSON bool
Copy link
Collaborator

@bradrydzewski bradrydzewski Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest backing out the changes to this file. The exec command is used for local development and testing only and we would never need / use json logging here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradrydzewski bradrydzewski bradrydzewski left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prune998 @CLAassistant @tphoney @bradrydzewski